Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] skip validator import if oneOf discriminator lookup is enabled #20497

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ctreatma
Copy link
Contributor

@ctreatma ctreatma commented Jan 17, 2025

The Go generator produces invalid code for oneOf models that have discriminators when useOneOfDiscriminatorLookup is set to true. In this case, the model imports gopkg.in/validator.v2 but does not use it because validation is skipped when discriminator lookup is enabled.

This updates the Go generator so that the validator import is skipped if discriminator lookup is enabled. In order to make this change I had to move the validator import from AbstractGoCodegen to GoClientCodegen; this is a safe change because the oneOf validation code only exists in the Go client generator templates, not in the other Go generators.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

@ctreatma ctreatma force-pushed the fix-go-validate-error branch from a3bb03c to 395cc51 Compare January 17, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant